Fix YOLO v4 example non-fatal teardown error #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
- fixes lack of multiprocess thread pool teardown in TF Mirrored strategy as stated in tensorflow/tensorflow#50487 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_yolo_example
branch
from
c87564c
to
64db246
Compare
awolant
approved these changes
Mar 16, 2022
klecki
approved these changes
Mar 16, 2022
|
!build |
JanuszL
commented
Mar 16, 2022
| @@ -114,6 +112,7 @@ def dataset_fn(input_context): | |||
|
|
|||
| multigpu = kwargs.get("multigpu") | |||
| strategy = tf.distribute.MirroredStrategy() if multigpu else tf.distribute.get_strategy() | |||
| atexit.register(strategy._extended._collective_ops._pool.close) # type: ignore | |||
|
CI MESSAGE: [4161314]: BUILD STARTED |
JanuszL
changed the title
|
CI MESSAGE: [4161314]: BUILD PASSED |
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
- fixes lack of multiprocess thread pool teardown in TF Mirrored strategy as stated in tensorflow/tensorflow#50487 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
- fixes lack of multiprocess thread pool teardown in TF Mirrored strategy as stated in tensorflow/tensorflow#50487 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TF Mirrored strategy as stated in OSError: [Errno 9] Bad file descriptor raised on program exit tensorflow/tensorflow#50487
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
TF Mirrored strategy as stated in OSError: [Errno 9] Bad file descriptor raised on program exit tensorflow/tensorflow#50487
Additional information:
Affected modules and functionalities:,
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2338