Remove the compose operator from the fn API table #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as the compose operator is not supported in the functional API this PR removes it from the supported OP table Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
|
mzient
reviewed
Mar 29, 2022
docs/operations_table.py
Outdated
Comment on lines
88
to
89
| if op_name.lower() in removed_ops: | ||
| fn_string = "NA" |
There was a problem hiding this comment.
Why .lower()? I think it should use either ops style OperatorName or fn style operator_name, not yet another variant.
There was a problem hiding this comment.
I'd recommend creating a function def has_fn_variant(op_name) or similar
def has_fn_variant(op_name):
no_fn_list = ['Compose']
return False if op_name in no_fn_list else True
then use it here and in line 106
docs/operations_table.py
Outdated
| @@ -80,6 +85,8 @@ def fn_to_op_table(out_filename): | |||
| if m is not None and hasattr(m, op_name): | |||
| op_string = link_formatter.format(op = op_full_name, module = module_name) | |||
| fn_string = link_formatter.format(op = to_fn_name(op_full_name), module = to_fn_module(module_name)) | |||
| if op_name.lower() in removed_ops: | |||
| fn_string = "NA" | |||
There was a problem hiding this comment.
nitpick: Maybe "Not Applicable" or "N/A".
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [4263231]: BUILD STARTED |
|
CI MESSAGE: [4263231]: BUILD FAILED |
|
CI MESSAGE: [4263231]: BUILD PASSED |
|
The most recent: |
mzient
approved these changes
Mar 29, 2022
jantonguirao
approved these changes
Mar 29, 2022
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
- as the compose operator is not supported in the functional API this PR removes it from the supported OP table Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
- as the compose operator is not supported in the functional API this PR removes it from the supported OP table Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API this PR removes it from the supported OP table
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
API this PR removes it from the supported OP table
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A