Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TL0 test that runs on more than 1 GPU #3772

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 30, 2022

  • adds a test case that runs more than 1 GPU (usually 2)
    to test cross-device functionalities
  • unifies multidevice gtest naming

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • adds a test case that runs more than 1 GPU (usually 2)
    to test cross-device functionalities

  • unifies multidevice gtest naming

Additional information:

Affected modules and functionalities:

  • qa tests
  • mulitdevice gtest test naming

Key points relevant for the review:

  • if any test needs to be added

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-2677

- adds a test case that runs more than 1 GPU (usually 2)
  to test cross-device functionalities

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4271118]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4271118]: BUILD FAILED

exit 1
fi

"$FULLPATH" --gtest_filter="*MultiDevice*:*SyncCrossDevice*:*FreeOnAnotherDevice*:*GetResource_Device_RangeCheck*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea (maybe for followup): Come up with a single prefix/pattern to refer to C++ multi-gpu tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jantonguirao jantonguirao self-assigned this Mar 30, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4273465]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4273465]: BUILD FAILED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Mar 31, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4281247]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4281550]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4281550]: BUILD PASSED

@JanuszL JanuszL merged commit 8e36311 into NVIDIA:main Mar 31, 2022
@JanuszL JanuszL deleted the multi_gpu_tests branch March 31, 2022 16:30
@JanuszL JanuszL added the important-fix Fixes an important issue in the software or development environment. label Mar 31, 2022
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
- adds a test case that runs more than 1 GPU (usually 2)
  to test cross-device functionalities
- unifies multidevice gtest naming

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
- adds a test case that runs more than 1 GPU (usually 2)
  to test cross-device functionalities
- unifies multidevice gtest naming

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important-fix Fixes an important issue in the software or development environment.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants