Add experimental support for if statements in DALI #4561
Conversation
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
force-pushed
the
experimental-if-support
branch
from
cd1c9d7
to
093295e
Compare
|
!build |
|
CI MESSAGE: [6990000]: BUILD STARTED |
|
CI MESSAGE: [6990000]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [6996655]: BUILD STARTED |
|
CI MESSAGE: [6996655]: BUILD FAILED |
| f" at {self.stack_depth() -1}:" | ||
| f" split({produced_data_node}, predicate={predicate}.")) | ||
| self._is_registration_allowed = False | ||
| true, false = fn._conditional.split(produced_data_node, predicate=predicate) |
There was a problem hiding this comment.
true_node or something like this would be less confusing. At the beginning I thought it was a boolean
dali/python/nvidia/dali/data_node.py
Outdated
| def __hash__(self) -> int: | ||
| return hash(str(self) + str(self.source)) |
There was a problem hiding this comment.
that's unique, right?
There was a problem hiding this comment.
Should be, but thinking about it, maybe it would be better to use just the repr or string as the keys in the sets. I cannot use the DataNode directly, as it has the __equal__ overloaded to return the arithmetic op.
I could use AutoGraph to replace the comparisons with something else, but I'm not convinced if it's not to many changes and differently working arithmetic ops depending on the mode.
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [7000974]: BUILD STARTED |
|
CI MESSAGE: [7000974]: BUILD FAILED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [7008148]: BUILD STARTED |
|
CI MESSAGE: [7008148]: BUILD PASSED |
| # if pred_node: | ||
| # some_op() | ||
| # if pred_nested: | ||
| # some_other_op() |
There was a problem hiding this comment.
| # some_other_op() | |
| # some_nested_op() |
nitpick
There was a problem hiding this comment.
I will fix it in a followup
klecki
added
the
conditional execution
Utilize AutoGraph to capture if statements as a function that gets branches as callables passed as arguments. Trace the code within both branches, detecting the usage of DataNode. Each pipeline has a stack of previously checked conditions and entered branches. Whenever an operator is called within some condition block, its outputs (DataNodes) are registered as produced in this scope. Every time a DataNode is used as input to the operator or touched directly via `ag__.ld` it is looked up in the stack - if was produced on the same level, it is used, otherwise necessary split nodes are inserted. Outputs of both branches are detected by AutoGraph. Non-DataNode results are promoted to CPU constants (so they represent a batch), and results of both branches go into merge node. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Category: New feature
Description:
Utilize AutoGraph to capture if statements as function with callables wrapping the branches.
Trace the code within both branches, detecting the usage of DataNode.
Each pipeline has a stack of previously checked conditions and entered branches.
Whenever an operator is called within some condition block, it is registered as produced in this scope.
Every time it is used as input to the operator or touched directly via
ag__.ldit is looked up in the stackOutputs of both branches are detected by AutoGraph. Non-DataNode results are promoted to
CPU constants (so they represent a batch), and results of both branches go into merge node.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A