Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing WITH_DYNAMIC_* falgs to conda build #4597

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Jan 20, 2023

  • the cmake invocation lacked '-D' when passing values
    of WITH_DYNAMIC_* for nvJPEG, npp and cuFFT

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • the cmake invocation lacked '-D' when passing values
    of WITH_DYNAMIC_* for nvJPEG, npp and cuFFT

Additional information:

Affected modules and functionalities:

  • conda/recipe/build.sh

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • build DALI in conda in CI
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7065876]: BUILD STARTED

@stiepan stiepan self-assigned this Jan 20, 2023
@klecki klecki self-assigned this Jan 20, 2023
- the cmake invocation lacked '-D' when passing values
  of WITH_DYNAMIC_* for nvJPEG, npp and cuFFT

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7066955]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7066955]: BUILD PASSED

@JanuszL JanuszL merged commit 3a7474a into NVIDIA:main Jan 21, 2023
aderylo pushed a commit to zpp-dali-2022/DALI that referenced this pull request Mar 17, 2023
- the cmake invocation lacked '-D' when passing values
  of WITH_DYNAMIC_* for nvJPEG, npp and cuFFT

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants