Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nose2 test timer #4610

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Enable nose2 test timer #4610

merged 3 commits into from
Jan 26, 2023

Conversation

jantonguirao
Copy link
Contributor

Signed-off-by: Joaquin Anton janton@nvidia.com

Category:

Description:

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7102987]: BUILD STARTED

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7103373]: BUILD STARTED

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7103928]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7103928]: BUILD PASSED

@@ -9,7 +9,7 @@ topdir=$(cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )/..
source $topdir/qa/setup_test_common.sh

# Set runner for python tests
python_test_runner_package="nose nose2"
python_test_runner_package="nose nose2 nose2-test-timer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python_test_runner_package="nose nose2 nose2-test-timer"
python_test_runner_package="nose nose2 nose-timer nose2-test-timer"

@@ -18,7 +18,7 @@ python_invoke_test="${python_test_runner} ${python_test_args}"
# During the transition we run both
# When all tests are ported old will be removed
python_new_test_runner="python -m nose2"
Copy link
Contributor

@JanuszL JanuszL Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--with-timer --timer-top-n 20

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao jantonguirao marked this pull request as ready for review January 26, 2023 08:45
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7112899]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7112899]: BUILD FAILED

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7113770]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7113770]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7113770]: BUILD PASSED

@jantonguirao jantonguirao merged commit 456daaa into NVIDIA:main Jan 26, 2023
aderylo pushed a commit to zpp-dali-2022/DALI that referenced this pull request Mar 17, 2023
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants