Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanitizer error: memory & pipeline leaks #4619

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Conversation

szalpal
Copy link
Member

@szalpal szalpal commented Jan 26, 2023

Signed-off-by: szalpal mszolucha@nvidia.com

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

This PR fixes an error found by a sanitizer. There was a data_id_map leak, since it has not been deleted properly. Also, in one test, DALI Pipeline has not been destroyed properly.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal szalpal changed the title Fix sanitizer error: memory leak Fix sanitizer error: memory & pipeline leaks Jan 26, 2023
@JanuszL JanuszL self-assigned this Jan 26, 2023
@szalpal
Copy link
Member Author

szalpal commented Jan 26, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7120847]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7120847]: BUILD PASSED

@mzient mzient merged commit dc334c6 into NVIDIA:main Jan 27, 2023
aderylo pushed a commit to zpp-dali-2022/DALI that referenced this pull request Mar 17, 2023
* Fix sanitizer error: memory leak
* Fix pipeline leakt

Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal szalpal deleted the san_err_fix branch February 9, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants