Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing API utils mistake #4651

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

szalpal
Copy link
Member

@szalpal szalpal commented Feb 13, 2023

Signed-off-by: szalpal mszolucha@nvidia.com

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

I've made a mistake in #4642 . The required information there are about input properties, not output properties. Fixing this mistake. Also added prefixes to the function names, to make this clearer.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
Copy link
Member Author

szalpal commented Feb 13, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7293516]: BUILD STARTED

@banasraf banasraf self-assigned this Feb 13, 2023
@awolant awolant self-assigned this Feb 13, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7293516]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7293516]: BUILD PASSED

@szalpal szalpal merged commit 458b265 into NVIDIA:main Feb 13, 2023
stiepan pushed a commit that referenced this pull request Feb 13, 2023
I've made a mistake in #4642 . The required information there are about input properties, not output properties. Fixing this mistake. Also added prefixes to the function names, to make this clearer.

Signed-off-by: szalpal <mszolucha@nvidia.com>
aderylo pushed a commit to zpp-dali-2022/DALI that referenced this pull request Mar 17, 2023
I've made a mistake in NVIDIA#4642 . The required information there are about input properties, not output properties. Fixing this mistake. Also added prefixes to the function names, to make this clearer.

Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal szalpal deleted the ndim_dyte_layout_also_at_input branch February 9, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants