Fix API type check tests for frameworks #4670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test body was not executed correctly without the yield from. Adjust all the tests so they check for the expected error message. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [7380273]: BUILD STARTED |
JanuszL
approved these changes
Feb 21, 2023
klecki
changed the title
|
CI MESSAGE: [7380273]: BUILD FAILED |
banasraf
approved these changes
Feb 23, 2023
|
CI MESSAGE: [7380273]: BUILD PASSED |
aderylo
pushed a commit
to zpp-dali-2022/DALI
that referenced
this pull request
Mar 17, 2023
The test body was not executed correctly without the `yield from`. Adjust all the tests so they check for the expected error message. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix
Description:
The test body was not executed correctly without the
yield from. Adjust all the tests so they check for the expected error message.Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Adjust all the tests so they check for the expected error message.
Make sure the test for frameworks are actually executed.
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A