Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add augmentations used by AA #4699

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Add augmentations used by AA #4699

merged 4 commits into from
Mar 9, 2023

Conversation

stiepan
Copy link
Member

@stiepan stiepan commented Mar 8, 2023

Category:

New feature (non-breaking change which adds functionality)

Description:

Adds a set of augmentations used by RA/AA/TA

The augmentation wrapper is introduced here: #4694
tl;dr the wrapper handles computation of the parameter for the function, so that the augmentations can be used in uniform way just by passing the samples and specifying magnitude_bin from [0, num_magnitude_bins - 1] range that control "the strength" of the augmentation.

Additional information:

This is part of automatic augmentation module #4648

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-3230

@awolant awolant self-assigned this Mar 8, 2023
@stiepan stiepan added the automatic augmentations Automatic augmentations (AutoAugment, RandAugment, TrivialAugment and more) support in DALI. label Mar 8, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan
Copy link
Member Author

stiepan commented Mar 9, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7531175]: BUILD STARTED

Comment on lines +25 to +26
When called, the decorated augmentation expects:
* a single positional argument: batch o samples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When called, the decorated augmentation expects:
* a single positional argument: batch o samples
When called, the decorated augmentation expects:
* a single positional argument: batch of samples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot-on, I'll fix it in the #4702 when rebasing.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7531175]: BUILD PASSED

@stiepan stiepan merged commit 990d844 into NVIDIA:main Mar 9, 2023
@stiepan stiepan mentioned this pull request Mar 14, 2023
18 tasks
aderylo pushed a commit to zpp-dali-2022/DALI that referenced this pull request Mar 17, 2023
* Adds a set of augmentations used by the AA/RA/TA
* And the tests, mostly against PIL for those
---------

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@JanuszL JanuszL mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automatic augmentations Automatic augmentations (AutoAugment, RandAugment, TrivialAugment and more) support in DALI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants