-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add augmentations used by AA #4699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiepan
added
the
automatic augmentations
Automatic augmentations (AutoAugment, RandAugment, TrivialAugment and more) support in DALI.
label
Mar 8, 2023
stiepan
force-pushed
the
aut_aug_augments
branch
from
March 8, 2023 16:00
9e1ea19
to
f231760
Compare
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
stiepan
force-pushed
the
aut_aug_augments
branch
from
March 9, 2023 09:32
f231760
to
3975fac
Compare
!build |
CI MESSAGE: [7531175]: BUILD STARTED |
szalpal
approved these changes
Mar 9, 2023
Comment on lines
+25
to
+26
When called, the decorated augmentation expects: | ||
* a single positional argument: batch o samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
When called, the decorated augmentation expects: | |
* a single positional argument: batch o samples | |
When called, the decorated augmentation expects: | |
* a single positional argument: batch of samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot-on, I'll fix it in the #4702 when rebasing.
awolant
approved these changes
Mar 9, 2023
CI MESSAGE: [7531175]: BUILD PASSED |
18 tasks
aderylo
pushed a commit
to zpp-dali-2022/DALI
that referenced
this pull request
Mar 17, 2023
* Adds a set of augmentations used by the AA/RA/TA * And the tests, mostly against PIL for those --------- Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automatic augmentations
Automatic augmentations (AutoAugment, RandAugment, TrivialAugment and more) support in DALI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
Adds a set of augmentations used by RA/AA/TA
The
augmentation
wrapper is introduced here: #4694tl;dr the wrapper handles computation of the parameter for the function, so that the augmentations can be used in uniform way just by passing the samples and specifying magnitude_bin from
[0, num_magnitude_bins - 1]
range that control "the strength" of the augmentation.Additional information:
This is part of automatic augmentation module #4648
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3230