Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytorch-lightning example with Python3.6 #4722

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

stiepan
Copy link
Member

@stiepan stiepan commented Mar 17, 2023

Category:

Description:

Follow-up on #4719
Python3.6 uses some older pytorch-lightning version which requires passing the acceleration backend name explicitly.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply (the notebook itself is a test)
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7620969]: BUILD STARTED

@JanuszL JanuszL self-assigned this Mar 17, 2023
@awolant awolant self-assigned this Mar 17, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7620969]: BUILD PASSED

@klecki klecki merged commit 5c90372 into NVIDIA:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants