Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly tests after merging RunArg #4732

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

szalpal
Copy link
Member

@szalpal szalpal commented Mar 21, 2023

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

When introducing #4712 , I missed that some of L1 tests fail. This PR fixes those.

The fix is about removing glob * from test files specification. This had to be removed, since not all tests that suffice this globe shall be ran the same way.

Also, I've mistakenly added cupy and pytorch dependencies to the no_fw tests.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal
Copy link
Member Author

szalpal commented Mar 21, 2023

!build

@szalpal szalpal marked this pull request as ready for review March 21, 2023 16:22
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7662834]: BUILD STARTED

Copy link
Contributor

@mzient mzient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trigger the relevant tests in CI...

@mzient mzient self-assigned this Mar 21, 2023
@JanuszL JanuszL self-assigned this Mar 21, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7662834]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7662834]: BUILD PASSED

@JanuszL JanuszL merged commit 9c85f1c into NVIDIA:main Mar 22, 2023
@szalpal szalpal deleted the nightly_fix_runarg branch February 9, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants