Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building the DALI TF plugin for conda #4741

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 23, 2023

  • as there are problems with dependency resolution
    when Tensorflow conda build stops building DALI TF
    plugin for conda and use the regular one for conda
    tests

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • as there are problems with dependency resolution
    when Tensorflow conda build stops building DALI TF
    plugin for conda and use the regular one for conda
    tests

Additional information:

Affected modules and functionalities:

  • conda build

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • TL1_python-self-test_conda
    • TL0_tensorflow_plugin_conda
    • TL1_tensorflow_dataset_conda
    • TL1_jupyter_conda
    • TL1_self-test_conda
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL JanuszL marked this pull request as draft March 23, 2023 17:21
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7689370]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7689436]: BUILD STARTED

- as there are problems with dependency resolution
  when Tensorflow conda build stops building DALI TF
  plugin for conda and use the regular one for conda
  tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7691182]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7691182]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7700164]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7700164]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7700164]: BUILD PASSED

@JanuszL JanuszL marked this pull request as ready for review March 27, 2023 08:21
pushd ../..
source ./qa/test_template.sh
popd
pushd ../TL1_tensorflow_dataset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and where is the enable_conda/disable_conda then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yak. Missed that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7723764]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7723764]: BUILD PASSED

@JanuszL JanuszL merged commit fc0467a into NVIDIA:main Mar 29, 2023
@JanuszL JanuszL deleted the rework_conda_build branch March 29, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants