Add a native dataloader to RN50 PyTorch example #4807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [8078512]: BUILD STARTED |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
CI MESSAGE: [8078512]: BUILD PASSED |
JanuszL
changed the title
- extends DALI RN50 PyOtrch example based on https://github.com/NVIDIA/apex/tree/master/examples/imagenet by adding a native dataloader and easy ability to switch between DALI on and DALI off Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
stiepan
reviewed
Apr 26, 2023
stiepan
approved these changes
Apr 26, 2023
JanuszL
commented
Apr 26, 2023
JanuszL
commented
Apr 26, 2023
| def __iter__(self): | ||
| return self | ||
|
|
||
| def __next__(self): |
There was a problem hiding this comment.
I added this on top of the original APEX example to make it more aligned with DALI iterator.
|
Btw. Do we run the baseline anyhow in CI? |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Added a basic run (to check if the script works). |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
stiepan
reviewed
Apr 26, 2023
stiepan
approved these changes
Apr 26, 2023
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [8089640]: BUILD STARTED |
klecki
approved these changes
Apr 26, 2023
Comment on lines
291
to
296
| pipe.build() | ||
| train_loader = DALIClassificationIterator(pipe, reader_name="Reader", | ||
| last_batch_policy=LastBatchPolicy.PARTIAL, | ||
| auto_reset =True) | ||
|
|
||
| pipe = create_dali_pipeline(batch_size=args.batch_size, |
There was a problem hiding this comment.
Nitpick, my eyes hurt due to overwriting of the pipeline.
Comment on lines
331
to
340
| train_loader = torch.utils.data.DataLoader( | ||
| train_dataset, batch_size=args.batch_size, shuffle=(train_sampler is None), | ||
| num_workers=args.workers, pin_memory=True, sampler=train_sampler, collate_fn=collate_fn) | ||
|
|
||
| val_loader = torch.utils.data.DataLoader( | ||
| val_dataset, | ||
| batch_size=args.batch_size, shuffle=False, | ||
| num_workers=args.workers, pin_memory=True, | ||
| sampler=val_sampler, | ||
| collate_fn=collate_fn) |
There was a problem hiding this comment.
Can you format it in the same way?
Comment on lines
312
to
321
| train_dataset = datasets.ImageFolder( | ||
| traindir, | ||
| transforms.Compose([ | ||
| transforms.RandomResizedCrop(crop_size), | ||
| transforms.RandomHorizontalFlip(), | ||
| ])) | ||
| val_dataset = datasets.ImageFolder(valdir, transforms.Compose([ | ||
| transforms.Resize(val_size), | ||
| transforms.CenterCrop(crop_size), | ||
| ])) |
There was a problem hiding this comment.
Can you format it in the same way?
Comment on lines
88
to
89
| parser.add_argument('--disable_dali', default=False, action='store_true', | ||
| help='If use DALI at all') |
There was a problem hiding this comment.
Suggested change
| parser.add_argument('--disable_dali', default=False, action='store_true', | |
| help='If use DALI at all') | |
| parser.add_argument('--disable_dali', default=False, action='store_true', | |
| help='Disable DALI data loader and use native PyTorch one instead.') |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [8089640]: BUILD FAILED |
|
CI MESSAGE: [8089640]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/NVIDIA/apex/tree/master/examples/imagenet
by adding a native dataloader and easy ability to switch between DALI on and DALI off
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
https://github.com/NVIDIA/apex/tree/master/examples/imagenet
by adding a native dataloader and easy ability to switch between DALI on and DALI off
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A