Fix race condition in the CPU numpy reader #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when the last sample in the numpy reader is duplicated due to padding, the reader tries to read the same sample to the same memory, but from different clones of it concurrently. What is more the memory that is read can be allocated and deallocated concurrently. This PR removed this redundant and dangerous work, making sure that each sample is read only once. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [8256693]: BUILD STARTED |
|
CI MESSAGE: [8256693]: BUILD PASSED |
jantonguirao
approved these changes
May 12, 2023
klecki
approved these changes
May 12, 2023
stiepan
pushed a commit
that referenced
this pull request
May 12, 2023
- when the last sample in the numpy reader is duplicated due to padding, the reader tries to read the same sample to the same memory, but from different clones of it concurrently. What is more the memory that is read can be allocated and deallocated concurrently. This PR removed this redundant and dangerous work, making sure that each sample is read only once. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Closed
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
- when the last sample in the numpy reader is duplicated due to padding, the reader tries to read the same sample to the same memory, but from different clones of it concurrently. What is more the memory that is read can be allocated and deallocated concurrently. This PR removed this redundant and dangerous work, making sure that each sample is read only once. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to padding, the reader tries to read the same
sample to the same memory, but from different clones of it
concurrently. This PR removed this
redundant and dangerous work, making sure that each sample is read
only once.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
due to padding, the reader tries to read the same
sample to the same memory, but from different clones of it
concurrently. This PR removed this
redundant and dangerous work, making sure that each sample is read
only once.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A