Disable FITS test when not building with CFITSIO support. Fix build without libTIFF. #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
commented
May 24, 2023
| @@ -19,7 +19,7 @@ collect_test_sources(DALI_TEST_SRCS PARENT_SCOPE) | |||
|
|
|||
| if (NOT BUILD_LIBTIFF) | |||
| list(REMOVE_ITEM DALI_SRCS | |||
| ${DALI_SRC_DIR}/dali/image/tiff_libtiff.cc | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/tiff_libtiff.cc | |||
There was a problem hiding this comment.
Setting DALI_SRC_DIR is not mandatory and it didn't work with a local build.
klecki
approved these changes
May 24, 2023
mzient
changed the title
awolant
approved these changes
May 24, 2023
|
CI MESSAGE: [8396633]: BUILD STARTED |
JanuszL
approved these changes
May 24, 2023
|
CI MESSAGE: [8396633]: BUILD FAILED |
|
CI MESSAGE: [8396633]: BUILD PASSED |
JanuszL
pushed a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
…ithout libTIFF. (NVIDIA#4866) * Disable FITS test when not building with CFITSIO support. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
This PR fixes broken test build without CFITSIO support. It also fixes long-broken build without libtiff (it relied on some environment variables that we set in our CI, but which are not mandatory).
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A