Fix parsing numpy header #4903
Merged
Fix parsing numpy header #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
JanuszL
approved these changes
Jun 12, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
|
!build |
|
CI MESSAGE: [8610899]: BUILD STARTED |
JanuszL
approved these changes
Jun 12, 2023
mzient
reviewed
Jun 12, 2023
Comment on lines
+206
to
+207
| ndims = list(range(33)) | ||
| with tempfile.TemporaryDirectory(prefix=gds_data_root) as test_data_root: |
There was a problem hiding this comment.
Do we really need to test all of them? Wouldn't a small subset like 1, 2, 3, 7, 16, 32 (or something more informed) do? Of course, if it doesn't affect the test time in a substantial way, we can keep all of them.
There was a problem hiding this comment.
The most interesting case is 21, as that has minimal padding after the header, which makes it sensitive to small offset errors. But the test is very simple and lightweight so I went for all the cases.
mzient
approved these changes
Jun 12, 2023
|
CI MESSAGE: [8610899]: BUILD PASSED |
stiepan
added a commit
that referenced
this pull request
Jun 12, 2023
* Fix offset at which a null character is added in the header buffer * Add a test aimed to catch such bugs in header reading and parsing --------- Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
JanuszL
pushed a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
* Fix offset at which a null character is added in the header buffer * Add a test aimed to catch such bugs in header reading and parsing --------- Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
In #4897, I moved the calculation of the header start pointer (
header = token_mem.get() + token_len;) down in the function, but setting null-termination character stayed higher, which means that the\0is settoken_lenbytes too early.Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A