-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libabseil as a runtime DALI dependency in conda #4907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI MESSAGE: [8633772]: BUILD STARTED |
CI MESSAGE: [8633772]: BUILD FAILED |
CI MESSAGE: [8638425]: BUILD STARTED |
CI MESSAGE: [8638425]: BUILD PASSED |
- libprotobuf-static DALI link statically depends on libabseil so we need to add it to a runtime dependencies Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
changed the title
Pin libprotobuf-static version in conda
Add libabseil as a runtime DALI dependency in conda
Jun 19, 2023
CI MESSAGE: [8677498]: BUILD STARTED |
CI MESSAGE: [8677498]: BUILD FAILED |
CI MESSAGE: [8677498]: BUILD PASSED |
stiepan
approved these changes
Jun 20, 2023
banasraf
approved these changes
Jun 20, 2023
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
- libprotobuf-static DALI link statically depends on libabseil so we need to add it to a runtime dependencies Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to add it to a runtime dependencies
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
we need to add it to a runtime dependencies
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A