Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libabseil as a runtime DALI dependency in conda #4907

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Jun 13, 2023

  • libprotobuf-static DALI link statically depends on libabseil so
    we need to add it to a runtime dependencies

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • libprotobuf-static DALI link statically depends on libabseil so
    we need to add it to a runtime dependencies

Additional information:

Affected modules and functionalities:

  • conda/recipe/meta.yaml

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • TL1_python-self-test_conda
    • TL1_jupyter_conda
    • TL1_self-test_conda
    • TL1_tensorflow_dataset_conda
    • TL0_tensorflow_plugin_conda
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL JanuszL marked this pull request as draft June 13, 2023 23:04
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8633772]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8633772]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8638425]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8638425]: BUILD PASSED

- libprotobuf-static DALI link statically depends on libabseil so
  we need to add it to a runtime dependencies

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL JanuszL changed the title Pin libprotobuf-static version in conda Add libabseil as a runtime DALI dependency in conda Jun 19, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8677498]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8677498]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8677498]: BUILD PASSED

@JanuszL JanuszL marked this pull request as ready for review June 19, 2023 16:59
@stiepan stiepan self-assigned this Jun 20, 2023
@JanuszL JanuszL merged commit 986fc5f into NVIDIA:main Jun 20, 2023
3 checks passed
@JanuszL JanuszL deleted the pin_proto_conda branch June 20, 2023 12:16
JanuszL added a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
- libprotobuf-static DALI link statically depends on libabseil so
  we need to add it to a runtime dependencies

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants