Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA_remove_toolkit_include_dirs CMake function #4922

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Jun 23, 2023

  • fixes wrong negation in the condition in CUDA_remove_toolkit_include_dirs

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • fixes wrong negation in the condition in CUDA_remove_toolkit_include_dirs

Additional information:

Affected modules and functionalities:

  • cmake/CUDA_utils.cmake

Key points relevant for the review:

  • CMake syntax

Tests:

  • Existing tests apply
    • build
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- fixes wrong negation in the condition in CUDA_remove_toolkit_include_dirs

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Jun 23, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8729777]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8729794]: BUILD STARTED

@mzient mzient self-assigned this Jun 23, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8729777]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8729794]: BUILD PASSED

@JanuszL JanuszL merged commit abc4cd3 into NVIDIA:main Jun 27, 2023
3 checks passed
@JanuszL JanuszL deleted the fix_cmake branch June 27, 2023 09:57
JanuszL added a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
- fixes wrong negation in the condition in CUDA_remove_toolkit_include_dirs

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants