Fix memory_resource compilation in conda build #4939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [8910943]: BUILD STARTED |
awolant
approved these changes
Jul 10, 2023
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [8910943]: BUILD FAILED |
JanuszL
reviewed
Jul 10, 2023
|
CI MESSAGE: [8911520]: BUILD STARTED |
They still should reflect how we compile DALI, even if the standard library provided by conda has some modules as experimental. |
JanuszL
approved these changes
Jul 10, 2023
klecki
changed the title
|
CI MESSAGE: [8911520]: BUILD PASSED |
stiepan
pushed a commit
that referenced
this pull request
Jul 10, 2023
Update conda build to use C++17. DALI assumes C++17 for build env, conda for some reason forced C++14. Revert the code that conditionally includes memory_resource from experimental if an older version of standard library is present (as happens in conda env). Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
JanuszL
pushed a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
Update conda build to use C++17. DALI assumes C++17 for build env, conda for some reason forced C++14. Revert the code that conditionally includes memory_resource from experimental if an older version of standard library is present (as happens in conda env). Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix
Description:
Update conda build to use C++17.
DALI assumes C++17 for build env, conda for some reason forced C++14.
Revert the code that conditionally includes memory_resource from experimental
if an older version of standard library is present (as happens in conda env).
Additional information:
Affected modules and functionalities:
Conda build
Key points relevant for the review:
Tests:
This impacts the compilation.
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A