Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that GDS on SBSA is not tested for drivers below cuda 12.2 #5177

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Nov 20, 2023

  • as the SBSA started supporting GDS from CUDA 12.2 we should not test
    this using driver which don't support it

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:,

  • as the SBSA started supporting GDS from CUDA 12.2 we should not test
    this using driver which don't support it

Additional information:

Affected modules and functionalities:

  • dali/test/python/reader/test_numpy.py

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • test_numpy
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [10921791]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [10921791]: BUILD FAILED

@JanuszL JanuszL marked this pull request as draft November 20, 2023 12:39
@JanuszL JanuszL marked this pull request as ready for review November 20, 2023 12:39
- as the SBSA started supporting GDS from CUDA 12.2 we should not test
  this using driver which don't support it

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [10923628]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [10923628]: BUILD PASSED

@JanuszL JanuszL merged commit f128cb1 into NVIDIA:main Nov 21, 2023
4 checks passed
@JanuszL JanuszL deleted the limit_gds_aarch64 branch November 21, 2023 14:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants