Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a redundant call to Executor::GetTensorQueueSizes() #5225

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

AtomicVar
Copy link
Contributor

Category:

Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

There is a redundant call to Executor::GetTensorQueueSizes() in PipelinedExecutorImpl::GetTensorQueueSizes() because it's called twice (the first is useless).

Additional information:

Affected modules and functionalities:

Remove a Executor::GetTensorQueueSizes() from PipelinedExecutorImpl::GetTensorQueueSizes() in dali/pipeline/executor/pipelined_executor.h.

Key points relevant for the review:

None.

Tests:

I didn't test, it's just a tiny revision.

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11288056]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11288056]: BUILD PASSED

@szkarpinski
Copy link
Collaborator

Hello @AtomicVar , thank you for contributing to DALI! The change looks good.

To merge your PR, we need your commits to be signed-off. This is described in more detail in our contribution rules. Please rebase your branch with --signoff flag. Something like this should work:

git checkout patch-1
git rebase HEAD~2 --signoff
git push --force-with-lease origin patch-1

Signed-off-by: Shuai Guo <gs0801@foxmail.com>
@AtomicVar
Copy link
Contributor Author

@szkarpinski Thank you for your help, I rebased and added the signed-off line. Please check if it's OK now.

Copy link
Collaborator

@szkarpinski szkarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AtomicVar It's ok now, thank you

@szkarpinski
Copy link
Collaborator

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11317677]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11317677]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11317677]: BUILD PASSED

@szkarpinski szkarpinski merged commit 4c5dcf2 into NVIDIA:main Dec 8, 2023
5 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants