-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a redundant call to Executor::GetTensorQueueSizes() #5225
Conversation
CI MESSAGE: [11288056]: BUILD STARTED |
CI MESSAGE: [11288056]: BUILD PASSED |
Hello @AtomicVar , thank you for contributing to DALI! The change looks good. To merge your PR, we need your commits to be signed-off. This is described in more detail in our contribution rules. Please rebase your branch with
|
Signed-off-by: Shuai Guo <gs0801@foxmail.com>
@szkarpinski Thank you for your help, I rebased and added the signed-off line. Please check if it's OK now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AtomicVar It's ok now, thank you
!build |
CI MESSAGE: [11317677]: BUILD STARTED |
CI MESSAGE: [11317677]: BUILD FAILED |
CI MESSAGE: [11317677]: BUILD PASSED |
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
There is a redundant call to
Executor::GetTensorQueueSizes()
inPipelinedExecutorImpl::GetTensorQueueSizes()
because it's called twice (the first is useless).Additional information:
Affected modules and functionalities:
Remove a
Executor::GetTensorQueueSizes()
fromPipelinedExecutorImpl::GetTensorQueueSizes()
indali/pipeline/executor/pipelined_executor.h
.Key points relevant for the review:
None.
Tests:
I didn't test, it's just a tiny revision.
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A