Expose do_not_convert decorator #5263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiepan
reviewed
Jan 3, 2024
stiepan
reviewed
Jan 3, 2024
mzient
reviewed
Jan 5, 2024
mzient
reviewed
Jan 5, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
klecki
force-pushed
the
prevent-conversion
branch
from
6aab694
to
4e532c1
Compare
|
!build |
|
CI MESSAGE: [12163854]: BUILD STARTED |
|
CI MESSAGE: [12163854]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [12178360]: BUILD STARTED |
|
CI MESSAGE: [12178360]: BUILD FAILED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
force-pushed
the
prevent-conversion
branch
from
c561c8f
to
767b142
Compare
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [12183977]: BUILD STARTED |
|
CI MESSAGE: [12183977]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [12199236]: BUILD STARTED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [12199236]: BUILD PASSED |
stiepan
approved these changes
Jan 22, 2024
awolant
approved these changes
Jan 23, 2024
|
!build |
|
CI MESSAGE: [12277308]: BUILD STARTED |
|
CI MESSAGE: [12277308]: BUILD PASSED |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: New Feature, Bugfix
Description:
Exposes a new decorator, that allows to disable the autograph conversion of some user code in the conditional mode.
This decorator works only on functions that are called from pipeline definition and are not defined in a scope of already converted function (the simple example is a factory function to create
sourcefor external_source which needs to be declared with this decorator outside of@pipeline_def).Based on discussion, I used the lighter variant of the decorator
Additional information:
Affected modules and functionalities:
nvidia.dali.pipeline, autograph, conditional mode
Key points relevant for the review:
Impact on numba, how heavy should the decorator be?
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A