Generalize iterator checkpointing tests #5278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
18 tasks
dali/test/python/checkpointing/test_dali_checkpointing_fw_iterators.py
Dismissed
Show dismissed
Hide dismissed
dali/test/python/checkpointing/test_dali_checkpointing_fw_iterators.py
Dismissed
Show dismissed
Hide dismissed
jantonguirao
approved these changes
Jan 17, 2024
banasraf
approved these changes
Jan 18, 2024
|
!build |
|
CI MESSAGE: [12183838]: BUILD STARTED |
18 tasks
|
CI MESSAGE: [12183838]: BUILD FAILED |
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
|
!build |
|
CI MESSAGE: [12186362]: BUILD STARTED |
|
CI MESSAGE: [12186362]: BUILD FAILED |
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
|
!build |
|
CI MESSAGE: [12198742]: BUILD STARTED |
|
CI MESSAGE: [12198742]: BUILD PASSED |
18 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
This change is a preparation for extending checkpointing support to other framework iterators.
I move all Pytorch tests from
test_dali_checkpointing.pyto a new file,test_dali_checkpointing_fw_iterators.py.A generic base class,
FwTestBaseis created. Tests for particular frameworks will inherit from it just asTestPytorchdoes.I also took an opportunity to add tests for pytorch's
DALIRaggedIterator, which wasn't testedAdditional information:
Affected modules and functionalities:
Checkpointing tests
Key points relevant for the review:
This way of testing iterators should work for those based on
base_iterator._DaliBaseIterator(PyTorch, MxNet, PaddlePaddle, JAX). TF iterator will be probably hard to fit into this scheme.Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A