Fix memory leak in C API test #5303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
mzient
reviewed
Feb 2, 2024
| @@ -1119,6 +1119,7 @@ TEST(CApiTest, CheckpointingTest) { | |||
| auto handle2 = CreateCheckpointingTestPipe(); | |||
| daliExternalContextCheckpoint restored_external_context{}; | |||
| daliRestoreFromSerializedCheckpoint(&handle2, cpt, n, &restored_external_context); | |||
| free(cpt); | |||
There was a problem hiding this comment.
It's more of a remark about the C API than this PR. It's generally not a good C API design when a function returns memory that is freed elsewhere, with generic C library calls. We should probably have a daliFree function.
mzient
approved these changes
Feb 2, 2024
klecki
approved these changes
Feb 2, 2024
|
!build |
|
CI MESSAGE: [12538840]: BUILD STARTED |
|
CI MESSAGE: [12538840]: BUILD PASSED |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
Checkpoint was not freed in C API test, resulting in a memory leak.
Additional information:
Affected modules and functionalities:
C API tests
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A