-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use small videos in checkpointing tests #5305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
CI MESSAGE: [12541620]: BUILD STARTED |
CI MESSAGE: [12541620]: BUILD PASSED |
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
szkarpinski
changed the title
[WiP] Experiments: make checkpointing tests faster
Use small videos in checkpointing tests
Feb 5, 2024
mzient
approved these changes
Feb 5, 2024
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
jantonguirao
approved these changes
Feb 12, 2024
!build |
CI MESSAGE: [12757511]: BUILD STARTED |
CI MESSAGE: [12757511]: BUILD PASSED |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other -- test optimization
Description:
Checkpointing tests are taking some time to complete (especially with sanitizer). Video reader tests take 60% of the time spent in
test_dali_checkpointing
.When testing checkpointing, we just want to see if the correct frames are produced after restoring. To do that, we don't need full resolution videos and small videos added in NVIDIA/DALI_extra#127 are fine.
In this PR I make checkpointing tests of
video_reader
andvideo_resize_reader
use small videos. This results in ~15x speedup in those tests (which should result in ~2x total speedup fortest_dali_checkpointing
)Additional information:
Affected modules and functionalities:
Checkpointing tests
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A