Bump protobuf version requirements in CMake. #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
CI MESSAGE: [12649705]: BUILD STARTED |
szkarpinski
approved these changes
Feb 7, 2024
jantonguirao
approved these changes
Feb 7, 2024
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
CI MESSAGE: [12649961]: BUILD STARTED |
jantonguirao
approved these changes
Feb 7, 2024
szkarpinski
approved these changes
Feb 7, 2024
|
CI MESSAGE: [12649961]: BUILD PASSED |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
DALI uses Protobuf API that is the preferred one since protobuf 3.6.1 (which is already quite old).
It won't compile with some older versions (we've accidentally checked that with 3.3.2)
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A