Fix inconsistent calls to nvml::Init and nvml::Shutdown #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszL
added
the
important-fix
|
CI MESSAGE: [12783002]: BUILD STARTED |
- in the worker thread and thread poll the nvml is called only for non-CPU pipelines but the shutdown is called unconditionally Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_nvml_shut
branch
from
2d1b384
to
1941091
Compare
|
CI MESSAGE: [12783062]: BUILD STARTED |
|
CI MESSAGE: [12787486]: BUILD STARTED |
|
CI MESSAGE: [12787486]: BUILD FAILED |
mzient
reviewed
Feb 13, 2024
dali/util/nvml.h
Outdated
| @@ -241,6 +241,43 @@ inline void Shutdown() { | |||
| CUDA_CALL(nvmlShutdown()); | |||
| } | |||
|
|
|||
|
|
|||
| class nvmlHandle { | |||
There was a problem hiding this comment.
We have NvmlError and NvmlBadAlloc, so I guess it'd be good to have Nvml... something.
I'm not convinced we should call it NvmlHandle, since it's not a handle nor does it wrap any handle.
Other names to consider:
NvmlScope
NvmlInstance
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
stiepan
reviewed
Feb 13, 2024
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [12807069]: BUILD STARTED |
stiepan
reviewed
Feb 14, 2024
|
CI MESSAGE: [12810692]: BUILD STARTED |
stiepan
reviewed
Feb 14, 2024
|
CI MESSAGE: [12810908]: BUILD STARTED |
mzient
approved these changes
Feb 14, 2024
stiepan
approved these changes
Feb 14, 2024
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [12813834]: BUILD STARTED |
stiepan
approved these changes
Feb 14, 2024
|
CI MESSAGE: [12813834]: BUILD PASSED |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only for non-CPU pipelines but the shutdown is called
unconditionally
RAII pattern
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
only for non-CPU pipelines but the shutdown is called
unconditionally
RAII pattern
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A