Set rpath at cmake level (do not wait for bundle-wheel) #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
force-pushed
the
rpath-nvimgcodec
branch
from
c93e1fb
to
1454756
Compare
JanuszL
reviewed
Feb 15, 2024
| @@ -213,6 +213,19 @@ else() | |||
| set(LIBTYPE SHARED) | |||
| endif() | |||
|
|
|||
|
|
|||
| foreach(rpath IN ITEMS | |||
There was a problem hiding this comment.
How it affects conda build?
There was a problem hiding this comment.
It shouldn't. Conda build doesn't care about those paths anyway, and resets the rpath completely
There was a problem hiding this comment.
OK, we are overwriting them anyway https://github.com/NVIDIA/DALI/blob/main/conda/dali_native_libs/recipe/build.sh#L216.
|
!build |
|
CI MESSAGE: [12841037]: BUILD STARTED |
|
CI MESSAGE: [12841037]: BUILD FAILED |
mzient
approved these changes
Feb 15, 2024
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
rpath-nvimgcodec
branch
from
1454756
to
f2ddd38
Compare
|
CI MESSAGE: [12842935]: BUILD STARTED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
CI MESSAGE: [12842935]: BUILD PASSED |
jantonguirao
commented
Feb 16, 2024
| @@ -279,6 +279,7 @@ if(BUILD_NVIMAGECODEC) | |||
| nvimgcodec_headers | |||
| URL https://developer.download.nvidia.com/compute/nvimgcodec/redist/nvimgcodec/linux-x86_64/nvimgcodec-linux-x86_64-0.2.0.6-archive.tar.xz | |||
| URL_HASH SHA512=6577a8ff5589400cdf5767aa4a507245527a96e48065f23f626dfc6ba13b136960cacfe7f61c345dc158ed0352e1e971834aec6fd98038649b08b250c3306aeb | |||
| DOWNLOAD_EXTRACT_TIMESTAMP 1 | |||
There was a problem hiding this comment.
this is to silence a warning
szalpal
approved these changes
Feb 16, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Category:
Other
Description:
Improvement: Set rpath during build and not later during bundle-wheel. This allows for doing pip install directly from build directory without the need to build a wheel, and still be able to detect nvimgcodec installed in the python directory.
Additional information:
Affected modules and functionalities:
experimental decoders
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A