-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DALI TF plugin source compilation during installation #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!build |
JanuszL
force-pushed
the
fix_TF_plugin_compilation
branch
from
April 29, 2024 20:34
e70f593
to
cb22e73
Compare
CI MESSAGE: [14613019]: BUILD STARTED |
- removes unnecessary escape characters from compilation commands for the DALI TF plugin stub and binary issues when the plugin is built from the source during installation. Before this change rpatch was incorrectly set to '$ORIGIN' instead of just $ORIGIN Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_TF_plugin_compilation
branch
from
April 29, 2024 20:45
cb22e73
to
9492422
Compare
CI MESSAGE: [14613294]: BUILD STARTED |
CI MESSAGE: [14613294]: BUILD FAILED |
jantonguirao
approved these changes
Apr 30, 2024
CI MESSAGE: [14629131]: BUILD STARTED |
klecki
approved these changes
Apr 30, 2024
CI MESSAGE: [14629131]: BUILD PASSED |
JanuszL
added a commit
that referenced
this pull request
Apr 30, 2024
- removes unnecessary escape characters from compilation commands for the DALI TF plugin stub and binary issues when the plugin is built from the source during installation. Before this change rpatch was incorrectly set to '$ORIGIN' instead of just $ORIGIN Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the DALI TF plugin stub and binary issues when the
plugin is built from the source during installation. Before
this change rpatch was incorrectly set to '$ORIGIN' instead
of just $ORIGIN
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
for the DALI TF plugin stub and binary issues when the
plugin is built from the source during installation. Before
this change rpatch was incorrectly set to '$ORIGIN' instead
of just $ORIGIN
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3955