Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memory padding from examples #5484

Merged

Conversation

jantonguirao
Copy link
Contributor

Category:

Other (examples)

Description:

Removes memory padding from examples, to avoid OOM errors

Additional information:

Affected modules and functionalities:

Examples

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Joaquin Anton <janton@nvidia.com>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JanuszL JanuszL self-assigned this May 27, 2024
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15347802]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15347802]: BUILD PASSED

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15354210]: BUILD STARTED

@awolant awolant self-assigned this May 27, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15354210]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15370847]: BUILD STARTED

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15373714]: BUILD STARTED

@jantonguirao jantonguirao merged commit 1ea44da into NVIDIA:main May 28, 2024
5 of 6 checks passed
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15373714]: BUILD PASSED

fversaci added a commit to fversaci/cassandra-dali-plugin that referenced this pull request Jul 1, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants