Add default schema and use it in OpSpec argument queries. #5500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Description:
Prior to this change it was possible to construct an OpSpec with a name of a nonexistent schema, but it was impossible to query it for arguments - even ones that were present in the OpSpec.
This change introduces a default schema which is used in argument queries in absence of a proper schema. This gives consistent results when querying for default values of built-in arguments.
Additional information:
Affected modules and functionalities:
OpSpec::[Try]Get[Repeated]Argument
Key points relevant for the review:
Tests:
OpSpecTest.EmptySchema
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A