Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device ID in s3_client_manager #5533

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Jun 18, 2024

  • s3_client_manager uses a thread to perform reading but
    by default uses GPU device 0. As it doesn't use GPU at all
    this PR changes the device ID to CPU_ONLY_DEVICE_ID

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

Additional information:

Affected modules and functionalities:

  • s3_client_manager

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- s3_client_manager uses a thread to perform reading but
  by default uses GPU device 0. As it doesn't use GPU at all
  this PR changes the device ID to CPU_ONLY_DEVICE_ID

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Jun 18, 2024

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15925224]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this Jun 18, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15925224]: BUILD PASSED

@JanuszL JanuszL merged commit 4b85040 into NVIDIA:main Jun 19, 2024
7 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants