Set affinity by device UUID. #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzient
force-pushed
the
FixNVMLDeviceQueries
branch
from
47e1985
to
68417ad
Compare
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
mzient
force-pushed
the
FixNVMLDeviceQueries
branch
from
47e1985
to
eb50e8d
Compare
|
CI MESSAGE: [16649134]: BUILD STARTED |
|
CI MESSAGE: [16649134]: BUILD FAILED |
|
CI MESSAGE: [16669228]: BUILD STARTED |
mzient
commented
Jul 17, 2024
| return dev; | ||
| } | ||
|
|
||
| void GetNVMLAffinityMask(cpu_set_t *mask, size_t num_cpus) { |
There was a problem hiding this comment.
This function is moved here from the header.
mzient
commented
Jul 17, 2024
| size_t cpu_set_size = (num_cpus + 63) / 64; | ||
| std::vector<unsigned long> nvml_mask_container(cpu_set_size); // NOLINT(runtime/int) | ||
| auto * nvml_mask = nvml_mask_container.data(); | ||
| nvmlDevice_t device = nvmlGetDeviceHandleForCUDA(device_idx); |
There was a problem hiding this comment.
This is the important line.
mzient
commented
Jul 17, 2024
| CPU_AND(mask, &nvml_set, ¤t_set); | ||
| } | ||
|
|
||
| void SetCPUAffinity(int core) { |
There was a problem hiding this comment.
Moved here from the header without any changes.
mzient
force-pushed
the
FixNVMLDeviceQueries
branch
from
fa6dd16
to
eb1e0f7
Compare
|
CI MESSAGE: [16669418]: BUILD STARTED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [16671324]: BUILD STARTED |
klecki
approved these changes
Jul 17, 2024
|
CI MESSAGE: [16671324]: BUILD PASSED |
banasraf
approved these changes
Jul 18, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
NVML and CUDA runtime use different device indices. Device UUID is a reliable way of establishing device identity.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A