Add lint as the first class, separate target to CMake #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [773772]: BUILD STARTED |
|
CI MESSAGE: [773772]: BUILD FAILED |
klecki
reviewed
Jun 7, 2019
cmake/lint.cmake
Outdated
| add_custom_target(${LINT_FILENAME} | ||
| DEPENDS ${LINT_STAMP_PATH}) | ||
| add_dependencies(lint ${LINT_FILENAME}) | ||
| endforeach(LINT_FILE) |
There was a problem hiding this comment.
You could wrap this in function that takes the list of files, root and additional arguments to lint (linelenght).
And just call it twice.
klecki
requested changes
Jun 7, 2019
|
CI MESSAGE: [773913]: BUILD STARTED |
|
CI MESSAGE: [773913]: BUILD FAILED |
- adds separate build step with lint - removes lint test Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [774213]: BUILD STARTED |
|
CI MESSAGE: [774213]: BUILD FAILED |
|
CI MESSAGE: [774701]: BUILD STARTED |
|
CI MESSAGE: [774701]: BUILD FAILED |
|
CI MESSAGE: [774701]: BUILD PASSED |
klecki
approved these changes
Jun 10, 2019
mzient
approved these changes
Jun 11, 2019
haoxintong
pushed a commit
to haoxintong/DALI
that referenced
this pull request
Jul 16, 2019
- adds separate build step with lint - removes lint test Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com