Try and fix CI for old CTK #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
fix_common_type
branch
2 times, most recently
from
c6968ab
to
d267ed6
Compare
gevtushenko
reviewed
Jun 23, 2023
gevtushenko
reviewed
Jun 23, 2023
miscco
force-pushed
the
fix_common_type
branch
10 times, most recently
from
6c9a3d3
to
fbbaf6b
Compare
miscco
commented
Jun 26, 2023
libcudacxx/include/cuda/std/detail/libcxx/include/__concepts/convertible_to.h
Show resolved
Hide resolved
miscco
force-pushed
the
fix_common_type
branch
4 times, most recently
from
60b2efe
to
c2e730f
Compare
gevtushenko
reviewed
Jun 27, 2023
libcudacxx/.upstream-tests/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp
Outdated
Show resolved
Hide resolved
gevtushenko
reviewed
Jun 27, 2023
libcudacxx/include/cuda/std/detail/libcxx/include/__expected/expected_base.h
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__type_traits/is_convertible.h
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__type_traits/is_swappable.h
Show resolved
Hide resolved
miscco
force-pushed
the
fix_common_type
branch
3 times, most recently
from
52a7754
to
1709b83
Compare
|
For the record, I did additional testing with nvrtc and nvcc, which passed with nvcc 12.1 and all standard modes |
jrhemstad
reviewed
Jun 28, 2023
jrhemstad
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
I haven't delved into all of the details of the changes here. I'll leave that to @wmaxey @griwes @senior-zero
|
To summarize the warning suppression discussion We can suppress the warnings with nvcc 11.3 onwards. Otherwise it is not supported. That only leaves 11.1 and 11.2 as problematic versions. My agreement with @senior-zero was that those two versions are fine to be "potentially broken" especially given that it is really easy to work around the issue on the user side |
gevtushenko
reviewed
Jun 28, 2023
griwes
approved these changes
Jun 28, 2023
Older nvcc does not know `nv_diag_supppress` but only `diag_suppress` so special case it
Old nvcc does not know constexpr variables on device, so move to `const` in those cases
Move to a member function
In particular, constrained friend functions are critical
The constrain breaks in earlier standard modes, so as a workaround remove the constraint from our internal `__construct_at` prior to c++20 and switch back to the proper `construct_at` with c++20 onwards
gevtushenko
reviewed
Jun 28, 2023
wmaxey
approved these changes
Jun 28, 2023
alliepiper
added a commit
to alliepiper/cccl
that referenced
this pull request
Mar 28, 2024
Adopt histogram script to new format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.