Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement iterator concepts #223

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Implement iterator concepts #223

merged 1 commit into from
Jul 26, 2023

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Jul 14, 2023

This implements C++20 iterator concepts such as input_iterator and friends

This is one of the main building blocks for ranges

@miscco miscco added feature request New feature or request. libcu++ For all items related to libcu++ labels Jul 14, 2023
@miscco miscco self-assigned this Jul 14, 2023
@miscco miscco linked an issue Jul 14, 2023 that may be closed by this pull request
[FEA]: Implement iterator concepts and update <iterator> to C++20 #62
Closed
ericniebler
ericniebler approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@ericniebler ericniebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave everything under include/ a hard look and found no problems. I did a very cursory review of the .upstream-tests/ and mostly skipped the changes in libcxx/test/ which look purely mechanical.

Overall it looks fantastic. Nice.

libcudacxx/libcxx/test/libcxx/iterators/trivial_iterators.pass.cpp Show resolved Hide resolved
@miscco miscco linked an issue Jul 19, 2023 that may be closed by this pull request
[FEA]: Implement iterator concepts #247
Closed
@miscco miscco removed a link to an issue Jul 19, 2023
[FEA]: Implement iterator concepts and update <iterator> to C++20 #62
Closed
@miscco miscco merged commit 372535c into NVIDIA:main Jul 26, 2023
368 checks passed
@miscco miscco deleted the implement_iterator_concepts branch July 26, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericniebler ericniebler ericniebler approved these changes

@griwes griwes Awaiting requested review from griwes

@wmaxey wmaxey Awaiting requested review from wmaxey

Assignees

@miscco miscco

Labels
feature request New feature or request. libcu++ For all items related to libcu++
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Implement iterator concepts
2 participants
@miscco @ericniebler