Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make libcudacxx respect CMake options for CUDA archs. #235

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Make libcudacxx respect CMake options for CUDA archs. #235

merged 2 commits into from
Jul 17, 2023

Conversation

wmaxey
Copy link
Member

@wmaxey wmaxey commented Jul 17, 2023 •
edited
Loading

Description

closes #234

  • Simplifies parsing of command line options
  • Makes virtual compute something that's easier to understand from CMake and lit frontend.
    • -Dcompute_archs='90-virtual 60 70 80 90' -> compute_90, sm_60/70/etc..

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wmaxey wmaxey requested review from a team as code owners July 17, 2023 22:21
@wmaxey wmaxey requested review from alliepiper and ericniebler and removed request for a team July 17, 2023 22:21
@wmaxey wmaxey merged commit ca0f635 into main Jul 17, 2023
368 checks passed
@miscco miscco deleted the fea/libcudacxx-compute-arch-enhancements branch March 7, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@griwes griwes griwes approved these changes

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper is a code owner automatically assigned from NVIDIA/cccl-cmake-codeowners

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Make libcudacxx respect CMake CUDA Arch options
2 participants
@wmaxey @griwes