[BUG]: Avoid deprecation warning for std::aligned_storage when building with c++23
#258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
elstehle and
gevtushenko
and removed request for
a team
miscco
added
thrust
miscco
force-pushed
the
deprecate_aligned_storage
branch
from
252a112
to
0e417ff
Compare
gevtushenko
reviewed
Jul 24, 2023
miscco
force-pushed
the
deprecate_aligned_storage
branch
from
0e417ff
to
722fd42
Compare
miscco
changed the title
std::aligned_storage when building with c++23std::aligned_storage when building with c++23
miscco
commented
Jul 24, 2023
miscco
force-pushed
the
deprecate_aligned_storage
branch
2 times, most recently
from
37f605e
to
2d5d5db
Compare
gevtushenko
approved these changes
Jul 26, 2023
… to avoid triggering warnings in user code
miscco
force-pushed
the
deprecate_aligned_storage
branch
from
2d5d5db
to
d8a322b
Compare
elstehle
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a respin of NVIDIA/thrust#1908
Currently including
<thrust/device_vector.h>breaks for gcc and clang when building for c++23.We are not putting any effort in for now to deprecated
aligned_storageourself but unblocking users.