Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor link to cooperative groups in CUDA programming guide #274

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 27, 2023

Description

Closes #273.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested review from a team as code owners July 27, 2023 10:02
@wence- wence- requested review from miscco and griwes and removed request for a team July 27, 2023 10:02
@rapids-bot
Copy link

rapids-bot bot commented Jul 27, 2023

Pull requests from external contributors require approval from a NVIDIA organization member with write permissions or greater before CI can begin.

Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wence-

Thanks a lot for bringing the PR over here. Could you please add "[skip-tests]" to your commit message. We want to avoid running extensive CI on documentation changes

@wence-
Copy link
Contributor Author

wence- commented Jul 27, 2023

Hi @wence-

Thanks a lot for bringing the PR over here. Could you please add "[skip-tests]" to your commit message. We want to avoid running extensive CI on documentation changes

Sure, does it need to be in the "subject line" or is anywhere in the body ok?

@wence-
Copy link
Contributor Author

wence- commented Jul 27, 2023

Done.

@miscco
Copy link
Collaborator

miscco commented Jul 27, 2023

Hi @wence-
Thanks a lot for bringing the PR over here. Could you please add "[skip-tests]" to your commit message. We want to avoid running extensive CI on documentation changes

Sure, does it need to be in the "subject line" or is anywhere in the body ok?

That is a very good question, I believe it should be in the subject line. We will see and learn ;)

@miscco
Copy link
Collaborator

miscco commented Jul 27, 2023

/ok to test

@miscco miscco merged commit b1b8e01 into NVIDIA:main Jul 27, 2023
368 checks passed
@miscco
Copy link
Collaborator

miscco commented Jul 27, 2023

Thanks a lot for the contribution 🎉

@wence- wence- deleted the wence/fix/docs-link branch July 27, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DOC]: Incorrect anchor link to cooperative groups in programming guide
2 participants