Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single-thread block reduction #287

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fix single-thread block reduction #287

merged 1 commit into from
Aug 1, 2023

Conversation

gevtushenko
Copy link
Collaborator

Description

closes #286

Fixes single-thread block reduction

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@gevtushenko gevtushenko requested review from a team as code owners July 28, 2023 20:47
@gevtushenko gevtushenko requested review from elstehle and griwes and removed request for a team July 28, 2023 20:47
miscco
miscco approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that adding the test is only a single line

@gevtushenko gevtushenko merged commit 2da0c1f into NVIDIA:main Aug 1, 2023
369 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@elstehle elstehle elstehle approved these changes

@griwes griwes Awaiting requested review from griwes griwes is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Single-thread block reduce compilation issues
3 participants
@gevtushenko @miscco @elstehle