Fix rgba export / filter output based on occupancy grid #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu Gendrin <matthieu.gendrin@orange.com>
|
Thanks for the contribution! Looks good to me -- and apologies for the delay. |
fnysalehi
pushed a commit
to fnysalehi/instant-ngp-rendering
that referenced
this pull request
May 14, 2024
…port Fix rgba export / filter output based on occupancy grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Testbed::get_rgba_on_gridmethod enables to export rgba samples along a dense grid of the scene.Only
nerf_network::inferenceis used, thus keeping some points set to 0 in density grid.This is as problem when the two info are different, eg if the latents in the empty zone have evolved due to collisions in the hashtables, or if the VR cleaning facility has been used.
This patch aims at setting to 0 all samples whose position is according to the density grid.