Skip to content
This repository has been archived by the owner on Nov 24, 2020. It is now read-only.

abc4.com #3717

Closed
NanoMeow opened this issue May 1, 2020 · 7 comments
Closed

abc4.com #3717

NanoMeow opened this issue May 1, 2020 · 7 comments
Labels
f: archived This issue was archived, submit new reports for new problems with this website. f: resolved This issue was resolved. t: breakage This issue was classified as breakage.

Comments

@NanoMeow
Copy link
Owner

NanoMeow commented May 1, 2020

Basic Information

Test link: https://www.abc4.com/news/local-news/air-force-salutes-essential-workers/
Category: breakage
Reported from: United States
Template version: 2

User Environment

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.129 Safari/537.36
Extension: Nano Adblocker 1.0.0.142

Additional Message

video player missing

@@||c.amazon-adsystem.com/aax2/apstag.js$script,domain=abc4.com
@NanoMeow NanoMeow added the s: untriaged This issue has not been triaged yet. label May 1, 2020
@jspenguin2017 jspenguin2017 added m: (pending) No maintainer has been assigned to this issue yet. s: backlog This issue is on the backlog. s: dispatched This issue was dispatched. Awaiting maintainers to respond. t: breakage This issue was classified as breakage. and removed s: untriaged This issue has not been triaged yet. labels May 1, 2020
@jspenguin2017
Copy link
Collaborator

jspenguin2017 commented May 1, 2020 •
edited
Loading

Other domains (posted on the Slack channel):

8newsnow.com
abc27.com
abc4.com
arklatexhomepage.com
bigcountryhomepage.com
binghamtonhomepage.com
borderreport.com
brproud.com
cbs17.com
cbs42.com
cenlanow.com
centexproud.com
centralillinoisproud.com
cnyhomepage.com
conchovalleyhomepage.com
counton2.com
dothanfirst.com
easttexasmatters.com
eetimes.com
everythinglubbock.com
fourstateshomepage.com
fox16.com
fox21news.com
fox43tv.com
fox44news.com
fox46.com
informnny.com
kark.com
keloland.com
kget.com
khon2.com
klfy.com
koin.com
kron4.com
krqe.com
ksn.com
ksnt.com
ktsm.com
kveo.com
kxan.com
kxnet.com
lasvegasnow.com
localdvm.com
localsyr.com
myarklamiss.com
mychamplainvalley.com
myhighplains.com
mypanhandle.com
mystateline.com
mysterywire.com
mytwintiers.com
mywabashvalley.com
nbc4i.com
news10.com
nwahomepage.com
nxsttv.com
ourquadcities.com
ozarksfirst.com
pahomepage.com
portlandscw.com
rochesterfirst.com
siouxlandproud.com
tamronhallshow.com
texomashomepage.com
tristatehomepage.com
upmatters.com
valleycentral.com
wane.com
wate.com
wavy.com
wboy.com
wbtw.com
wcia.com
wdtn.com
wearecentralpa.com
wearegreenbay.com
westernslopenow.com
wfla.com
wfxrtv.com
wiproud.com
wivb.com
wjbf.com
wjhl.com
wjtv.com
wkbn.com
wkrg.com
wkrn.com
wlns.com
wnct.com
woodtv.com
wowktv.com
wpri.com
wrbl.com
wric.com
wsav.com
wspa.com
wtnh.com
wtrf.com
wvillustrated.com
wvnstv.com
wwlp.com
wytv.com
yourbasin.com
yourbigsky.com
yourcentralvalley.com
yourerie.com

@mapx-
Copy link

mapx- commented May 2, 2020

If we add the generic:
@@||c.amazon-adsystem.com/aax2/apstag.js$script

do you see any "danger" ?

mapx- added a commit to uBlockOrigin/uAssets that referenced this issue May 2, 2020
@mapx-
https://github.com/NanoMeow/QuickReports/issues/3717
474019a
@jspenguin2017
Copy link
Collaborator

I think that's fine as long as no real ads get through.

@jspenguin2017 jspenguin2017 added f: resolved This issue was resolved. and removed m: (pending) No maintainer has been assigned to this issue yet. s: backlog This issue is on the backlog. s: dispatched This issue was dispatched. Awaiting maintainers to respond. labels May 2, 2020
gorhill added a commit to gorhill/uBlock that referenced this issue May 11, 2020
@gorhill
Add new scriptlet to allow blocking Amazon's apstag.js
f842ab6 
Related issues:
- NanoMeow/QuickReports#3717
- https://www.reddit.com/r/uBlockOrigin/comments/ghjqph/

The specific issue on the mentioned site is that the
site's code expect `window.apstag.fetchBids` to call
client-supplied function. The new scriptlet defuse this
by calling the client code with an empty array.
gorhill added a commit to uBlockOrigin/uAssets that referenced this issue May 11, 2020
@gorhill
Make use of new scriptlet apstag.js to minimize breakage
6be4a0c 
Related issue:
- NanoMeow/QuickReports#3717
gorhill added a commit to uBlockOrigin/uAssets that referenced this issue May 11, 2020
@gorhill
Make use of redirect scriptlet apstag.js to minimize breakage
b8b220d 
Related issue:
- NanoMeow/QuickReports#3717
@gorhill
Copy link

gorhill commented May 11, 2020

@jspenguin2017 Would you also add such scriptlet for https://imasdk.googleapis.com/js/sdkloader/ima3.js ? There are 90+ cases currently.

@jspenguin2017
Copy link
Collaborator

jspenguin2017 commented May 11, 2020 •
edited
Loading

@gorhill

I did try to make a surrogate for ima3.js a few years ago. I implemented it based on the official documentation, but my surrogate does not always work and I didn't get around to fix all the issues.

https://github.com/jspenguin2017/uBlockProtector/blob/master/src/resources/ima3.js

I spent quite a bit of time debugging it, recalling from memory:

  • Some websites correctly handle the case where ima3.js fails to load, but expect ads to load if ima3.js loads
  • Some websites expect a specific inheritance chain even though the official documentation does not say anything about it
  • Some weird requests to undefined, [object Object], etc. only when the surrogate is used (I couldn't figure out why)

I tried to universally redirect ima3.js to the surrogate and it didn't go so well, so I ended up disabling the redirect and that file is sitting there unused for years now. I'm not sure if ima3.js has changed since then but I would say the surrogate is OK for use on a case by case basis back then.

I'm not sure what's happening in the commit comments, but just to be clear, I'm not trying to pass the debugging task to you, although you're certainly more than welcomed to contribute.

@gorhill
Copy link

gorhill commented May 11, 2020

I'm not trying to pass the debugging task to you

It's not the point I was trying to make, I wanted to make the point that this kind of requests -- even more so non-trivial ones (I also looked into this one in the past) -- should not be directed only at me, or anyone specific for that matter, it should be made into an official request on an issue tracker, so that anyone can contribute a solution.

@jspenguin2017
Copy link
Collaborator

Yep, I agree.

Personally, I'm not too concerned with whitelisting though, since no ads get through. But if someone is concerned, feel free to open an issue in an appropriate issues tracker.

JustOff pushed a commit to gorhill/uBlock-for-firefox-legacy that referenced this issue Jun 20, 2020
@gorhill @JustOff
Add new scriptlet to allow blocking Amazon's apstag.js
105578d 
Related issues:
- NanoMeow/QuickReports#3717
- https://www.reddit.com/r/uBlockOrigin/comments/ghjqph/

The specific issue on the mentioned site is that the
site's code expect `window.apstag.fetchBids` to call
client-supplied function. The new scriptlet defuse this
by calling the client code with an empty array.
@github-actions github-actions bot added the f: archived This issue was archived, submit new reports for new problems with this website. label Aug 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
f: archived This issue was archived, submit new reports for new problems with this website. f: resolved This issue was resolved. t: breakage This issue was classified as breakage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gorhill @jspenguin2017 @mapx- @NanoMeow