Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reformat stark code after prettier update #2538

Conversation

SuperITMan
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Code is not well formatted according to new Prettier config.

What is the new behavior?

Code is formatted by Prettier with new configuration.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@SuperITMan SuperITMan added the comp: stark-all To apply for all Stark modules label Mar 10, 2021
@SuperITMan SuperITMan added this to the 10.2.0 milestone Mar 10, 2021
@SuperITMan SuperITMan requested a review from nicanac March 10, 2021 11:01
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.437% when pulling 3890784 on SuperITMan:feature/reformat-stark-code-after-prettier-update into b790662 on NationalBankBelgium:master.

Copy link
Contributor

@nicanac nicanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nicanac nicanac merged commit e97fbe3 into NationalBankBelgium:master Mar 10, 2021
@SuperITMan SuperITMan deleted the feature/reformat-stark-code-after-prettier-update branch February 5, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: stark-all To apply for all Stark modules type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants