Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused components from old mintable-fungible-token #462

Closed
mfornet opened this issue Jan 23, 2021 · 1 comment · Fixed by #499
Closed

Remove unused components from old mintable-fungible-token #462

mfornet opened this issue Jan 23, 2021 · 1 comment · Fixed by #499
Assignees
@sept-en
Labels
enhancement good first issue Good for newcomers P1

Comments

@mfornet
Copy link
Contributor

mfornet commented Jan 23, 2021

This repository currently contains several components relevant to the deployment and the execution of the token-connector. Most of them are related to an old version using custom mintable-fungible-token. See also #420 for unused commands that our cli is supporting.

All this components should be detected and removed from this repository. In case some of them are relevant to run some cli commands interacting with the token-connector or for tests, the logic should be imported directly from token-connector.

To remove:

  • Contracts on Near side.
  • Contracts on Ethereum side.
  • Cli commands that are no longer required.
@mfornet mfornet self-assigned this Jan 23, 2021
@mfornet mfornet mentioned this issue Jan 23, 2021
Closed
@mfornet mfornet added the good first issue Good for newcomers label Jan 23, 2021
@sept-en
Copy link
Contributor

sept-en commented Jan 28, 2021

I will take a look at this next week.

sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 16, 2021
@sept-en
(Near-One#462) Remove mintable-fungible-token
516eebd
@sept-en sept-en mentioned this issue Feb 16, 2021
Merged
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 17, 2021
@sept-en
(Near-One#462) Remove mintable-fungible-token
02e0841
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 17, 2021
@sept-en
(Near-One#462) Remove mintable-fungible-token
cd7d597
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 18, 2021
@sept-en
(Near-One#462) Remove mintable-fungible-token.
fa0e13d
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 18, 2021
@sept-en
(Near-One#462) Remove mintable-fungible-token.
09c9dac
mfornet pushed a commit that referenced this issue Feb 18, 2021
@sept-en
(#462) Remove mintable-fungible-token. (#499)
2f1795c
karim-en pushed a commit that referenced this issue Dec 20, 2021
@sept-en
(#462) Remove mintable-fungible-token. (#499)
efb9932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sept-en sept-en

Labels
enhancement good first issue Good for newcomers P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove old mintable-fungible-token sept-en/rainbow-bridge
3 participants
@alexauroradev @sept-en @mfornet