Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the local deployment part of the README.md #467

Closed
7 tasks
alexauroradev opened this issue Jan 28, 2021 · 1 comment · Fixed by #485
Closed
7 tasks

Check the local deployment part of the README.md #467

alexauroradev opened this issue Jan 28, 2021 · 1 comment · Fixed by #485
Assignees
@sept-en
Labels
good first issue Good for newcomers

Comments

@alexauroradev
Copy link

We need to make sure that the current readme.md is providing the correct guidelines for the local deployment of the bridge.
One need:

  • Run the local NEAR node and Ganache
  • Deploy core bridge contracts (light clients, provers)
  • Deploy relayers
  • Check that relayers are sending transactions; transactions are normally executed
  • Deploy rainbow-token-connector
  • Create an ERC-20 token in Ganache (e.g. this one or any other).
  • Check the ERC-20 transfer to NEAR and back

The README.md should be updated, so an external person can do this walkthrough.
@alexauroradev alexauroradev added the good first issue Good for newcomers label Jan 28, 2021
@sept-en
Copy link
Contributor

sept-en commented Jan 28, 2021

I will take a look.

sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 5, 2021
@sept-en
(Near-One#467) Minor CLI improvements. Update README.
5b65516 
* CLI: make transfer functions callable directly from CLI (without
  "TESTING" prefix).
* CLI: improve `getErc20Balance` method.
* CLI: add `getBridgeOnNearBalance` method.
* Update README.
* Minor improvements.
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 8, 2021
@sept-en
(Near-One#467) Update README. CLI commands minor changes.
8cd5bc9 
* CLI: make aux methods (transfer and view-balance functionality)
  to be called through the TESTING subcommand again.
* CLI: `getBridgeOnNearBalance` - don't provide private key to the view
  method.
* Update README.
@chadoh chadoh mentioned this issue Feb 8, 2021
Merged
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 8, 2021
@sept-en
(Near-One#467) Update README.
a20485c
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 15, 2021
@sept-en
(Near-One#467) Minor CLI improvements. Update README.
f13678f 
* CLI: make transfer functions callable directly from CLI (without
  "TESTING" prefix).
* CLI: improve `getErc20Balance` method.
* CLI: add `getBridgeOnNearBalance` method.
* Update README.
* Minor improvements.
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 15, 2021
@sept-en
(Near-One#467) Update README. CLI commands minor changes.
eeefc49 
* CLI: make aux methods (transfer and view-balance functionality)
  to be called through the TESTING subcommand again.
* CLI: `getBridgeOnNearBalance` - don't provide private key to the view
  method.
* Update README.
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 15, 2021
@sept-en
(Near-One#467) Update README.
6c22fe3
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 17, 2021
@sept-en
(Near-One#467) Minor CLI improvements. Update README.
0fb88bf 
* CLI: make transfer functions callable directly from CLI (without
  "TESTING" prefix).
* CLI: improve `getErc20Balance` method.
* CLI: add `getBridgeOnNearBalance` method.
* Update README.
* Minor improvements.
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 17, 2021
@sept-en
(Near-One#467) Update README. CLI commands minor changes.
3004dc2 
* CLI: make aux methods (transfer and view-balance functionality)
  to be called through the TESTING subcommand again.
* CLI: `getBridgeOnNearBalance` - don't provide private key to the view
  method.
* Update README.
sept-en added a commit to sept-en/rainbow-bridge that referenced this issue Feb 17, 2021
@sept-en
(Near-One#467) Update README.
39ac1fa
mfornet added a commit that referenced this issue Feb 18, 2021
@sept-en @mfornet
Update local deployment guide. Improve CLI commands. (#485)
4ee7472 
* (#467) Minor CLI improvements. Update README.

* CLI: make transfer functions callable directly from CLI (without
  "TESTING" prefix).
* CLI: improve `getErc20Balance` method.
* CLI: add `getBridgeOnNearBalance` method.
* Update README.
* Minor improvements.

* (#467) Update README. CLI commands minor changes.

* CLI: make aux methods (transfer and view-balance functionality)
  to be called through the TESTING subcommand again.
* CLI: `getBridgeOnNearBalance` - don't provide private key to the view
  method.
* Update README.

* (#467) Update README.

* Update cli/index.js

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>

* Update README

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>

* Update README. Minor improvements and fixes.

* Update README: use `cli/index.js` as a rainbow cmd.

* Remove redundant code.

* Lint fixes.

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>
karim-en pushed a commit that referenced this issue Dec 20, 2021
@sept-en @mfornet
Update local deployment guide. Improve CLI commands. (#485)
e76a140 
* (#467) Minor CLI improvements. Update README.

* CLI: make transfer functions callable directly from CLI (without
  "TESTING" prefix).
* CLI: improve `getErc20Balance` method.
* CLI: add `getBridgeOnNearBalance` method.
* Update README.
* Minor improvements.

* (#467) Update README. CLI commands minor changes.

* CLI: make aux methods (transfer and view-balance functionality)
  to be called through the TESTING subcommand again.
* CLI: `getBridgeOnNearBalance` - don't provide private key to the view
  method.
* Update README.

* (#467) Update README.

* Update cli/index.js

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>

* Update README

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>

* Update README. Minor improvements and fixes.

* Update README: use `cli/index.js` as a rainbow cmd.

* Remove redundant code.

* Lint fixes.

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sept-en sept-en

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update local deployment guide. Improve CLI commands. sept-en/rainbow-bridge
2 participants
@alexauroradev @sept-en