-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Decouple RainbowConfig #412
Conversation
c2d250b
to
ca08ea4
Compare
…not distinguish if those are default values or user-specified
…ken-factory to in order to fix the transfer command relying on those config options
FINALLY all the tests are green again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Are there next steps after decoupling?
CI tests are flaky, I've rebuilt ethrelay catchup one. |
@frol couldn't find an update at |
@Kouprin It slipped through me when I merged master to my branch. I will see how it fits the new design. Do you think it should be part of the bridge CLI or should be a separate "executable"? |
Both are okay. I think it's a question of our understanding who is the clients of CLI. Adapter is built for testing purposes only. As adapter asks values from config that are changing in runtime, it's impossible to just pass the args. I guess putting it into CLI in preferable (as CLI is the only source for now who handles runtime-changing config values). |
@frol Please let me know your thoughts. I can move adapter into CLI in a separate commit, if we will decide to go this way. |
# Testing Plan * [x] The existing end-to-end testing suite pass * [x] Manual testing of README pass
Resolves #344
TODO:
eth-{tokenName}-address
)execute
should be treated as diff to the RainbowConfig)