Fix bug verifying merkle-patricia-tree proofs from ethereum #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made code more simple and robust
abacabadabacaba
approved these changes
Apr 14, 2021
karim-en
pushed a commit
that referenced
this pull request
Dec 20, 2021
* Fix bug while verifying MPT proofs from Ethereum Made code more simple and robust * Compile prover contract * Run rustfmt * Compile eth_prover contract * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code had several unhandled edge cases while verifying the proofs, and some valid proofs weren't accepted. This PR reimplements the verification in a simpler and more robust way.
Sources used for reference:
Added proof of concept in python with similar implementation: