Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add constexpr containers #187

Merged
merged 47 commits into from
Jan 17, 2023
Merged

add constexpr containers #187

merged 47 commits into from
Jan 17, 2023

Conversation

schaumb
Copy link
Contributor

@schaumb schaumb commented May 23, 2022

No description provided.

schaumb
schaumb commented May 24, 2022
View reviewed changes
include/magic_enum_containers.hpp

template<typename Parent, typename Iterator, typename Getter, typename Predicate>
struct FilteredIterator {
Parent parent;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very heavy class, probably parent and current must be enough

@Neargye Neargye added this to the 0.8.1 milestone May 25, 2022
@Neargye Neargye modified the milestones: 0.8.1, 0.8.2 Jun 28, 2022
@Neargye Neargye removed this from the 0.8.2 milestone Aug 8, 2022
@schaumb schaumb mentioned this pull request Nov 14, 2022
Closed
@florianbecker
Copy link
Contributor

@schaumb
So what's to do here? Why is this a draft PR? The last commits are 5 months ago.

I think we have to finish just one for the moment, and then we could discuss if we also want to add a magic_enum_map like #181.

@schaumb
Copy link
Contributor Author

schaumb commented Nov 14, 2022

@florianbecker
This PR is draft because it need to be add tests and documentation.

map: While I started to implement enum_map, I concluded this.

If you had time to add tests and documentation feel free to open another PR or PR to my fork's branch.

@Neargye Neargye assigned Neargye, schaumb and florianbecker and unassigned Neargye Nov 14, 2022
@florianbecker florianbecker mentioned this pull request Nov 16, 2022
Merged
florianbecker and others added 24 commits November 17, 2022 18:54
@florianbecker
Fix ambiguous std::get
9b2f62d
@florianbecker
Fix std::get again
505de1f
@florianbecker
Fix build
2b23471
@florianbecker
Code quality
8126141
@florianbecker
Fix iterator for windows build
1d0b2aa
@florianbecker
Insert tests for bitset
fd2e53d
@florianbecker
Workaround for gcc sign-compare is always nonzero
4e35c63
@florianbecker
Fix some visual studio foo
47920e3 
Write bitset test
@florianbecker
Some documentation for containers::array
e974060
@florianbecker
Insert array functions in documentation
1076ddb
@florianbecker
Update documentation
bb85906
@florianbecker
Try to fix visual studio for containers::set
e79d8b2
@florianbecker
Remove tuple_size again after testing
8c743c9
@florianbecker
Clean up test
cfee358
@florianbecker
Deactivate containers::flat_set
15861df
@florianbecker
Merge branch 'master' of https://github.com/Neargye/magic_enum into c…
8042e48 
…ontainers
@florianbecker
Insert reference of containers::bitset and containers::set
01bf7a4
@florianbecker
Fix windows build
1253ed9
@florianbecker
Insert examples for containers
5414236
@florianbecker
Insert examples
e695ca1
@florianbecker
Fix windows warning
3ef9f89
@florianbecker
Fix windows build
05175ef
@florianbecker
Fix version
b5e37cd
@schaumb
Merge pull request #2 from florianbecker/containers
7407bde 
Containers
@schaumb
Copy link
Contributor Author

schaumb commented Dec 23, 2022

@florianbecker made a lot of work on the tests and on the documentation. I mark this PR to ready for review.

@schaumb schaumb marked this pull request as ready for review December 23, 2022 14:53
@Neargye Neargye merged commit 533c950 into Neargye:master Jan 17, 2023
@Neargye Neargye mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neargye Neargye Neargye approved these changes

Assignees

@schaumb schaumb

@florianbecker florianbecker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schaumb @florianbecker @Neargye