Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent (async () => {})() from causing ASTring to throw an error. #35

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

FoxMoss
Copy link
Contributor

@FoxMoss FoxMoss commented Aug 15, 2023

The preserveParens option on acorn makes it use the (non-standard) ParenthesizedExpression node which cant be parsed by ASTring, making token based rewrites ineffective.

This took me hours to figure out.

@GreenyDEV GreenyDEV requested a review from Avad3 August 16, 2023 15:35
Copy link
Contributor

@Avad3 Avad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@Avad3 Avad3 merged commit 761e967 into NebulaServices:main Aug 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants